New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix resolve input not debounce #4199
Conversation
WalkthroughThe update encapsulates a minor yet potentially impactful adjustment within an operator's state management logic, alongside a straightforward version bump in the project's setup configuration. Specifically, it involves the refinement of function call parameters to possibly enhance or modify the logic for handling input fields and the increment of the project version, indicating progression and maintenance efforts. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v0.23.8 #4199 +/- ##
==================================================
Coverage ? 28.85%
==================================================
Files ? 769
Lines ? 97127
Branches ? 1128
==================================================
Hits ? 28026
Misses ? 69101
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!
ae048df
to
1f2ccdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (2)
- app/packages/operators/src/state.ts (1 hunks)
- setup.py (1 hunks)
Additional comments not posted (2)
setup.py (1)
19-19
: The version update from "0.23.7" to "0.23.8" is appropriate for a bug fix. Ensure that all dependencies and documentation are also updated accordingly if needed.app/packages/operators/src/state.ts (1)
336-336
: Removingctx
from the dependencies array ofuseCallback
forresolveInput
aligns with the goal of improving performance by not recreating the debounced function on everyctx
change. However, ensure thorough testing is conducted to verify that this change does not introduce unintended side effects, especially in scenarios wherectx
changes are significant and should trigger a re-evaluation.
What changes are proposed in this pull request?
Typo in PR #4152 regressed debounced resolution of operator input causing operator prompt to re-resolve input in every change and potentially degrading performance. Changes in this PR fixes the issue to ensure input schema is not resolved for every change.
How is this patch tested? If it is not, please explain why.
Using a dynamic operator.
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
fix the dynamic operator's input schema getting resolved for every change
What areas of FiftyOne does this PR affect?
fiftyone
Python library changesSummary by CodeRabbit