Python Panels #4528
Open
Python Panels #4528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-syntax-and-events
Py panels syntax and events
Ctx prompt
heatmap on click
Notify operation
imanjra
reviewed
Jun 24, 2024
| const handleEvent = | ||
| (event) => | ||
| (...args) => { | ||
| console.log(`Video event: ${event}`, ...args); |
There was a problem hiding this comment.
Looks like this needs to be wired up or removed
fix grid based views
fix resolve output for operators in app
fix missing python panel load error trace
debounce spaces updates to session
overridable panel not found component
initial python panel e2e test
imanjra
approved these changes
Jun 24, 2024
benjaminpkane
requested changes
Jun 25, 2024
| @@ -46,6 +46,7 @@ | |||
| "@textea/json-viewer": "^3.4.1", | |||
| "classnames": "^2.3.1", | |||
| "framer-motion": "^6.2.7", | |||
| "material-icons": "^1.13.12", | |||
There was a problem hiding this comment.
Why are we bringing it in when we already have @mui/icons-material? This will cause significant bloating otherwise.
There was a problem hiding this comment.
This is font-based and it's to support dynamic icon by name. In a separate PR, we should probably replace all the icons from @mui/icons-material to this instead. It will reduce build size/time
* add analytics consent to app * cleanup * update lock * update copy * fix tsconfigs * add z-index due to panel borders * call GA, add back Snackbar * run pr on py-panels-develop * build fixes * Fix setuptools in workflows (#4581) * omit setuptools 71.0.2 * <71
benjaminpkane
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
LGTM. Will update e2e screenshots in #4281
Note, documentation builds are failing 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python Panels