Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty view stats #738

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Fix empty view stats #738

merged 1 commit into from
Jan 5, 2021

Conversation

benjaminpkane
Copy link
Contributor

Resolves #737

A None value must be checked for because of SampleCollections __bool__ definition.

@benjaminpkane benjaminpkane added bug Bug fixes app Issues related to App features server Issues related to server features or changes labels Jan 5, 2021
@benjaminpkane benjaminpkane requested a review from a team January 5, 2021 22:49
@benjaminpkane benjaminpkane self-assigned this Jan 5, 2021
brimoor
brimoor approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminpkane benjaminpkane merged commit 5e29e7c into develop Jan 5, 2021
@benjaminpkane benjaminpkane deleted the bugs branch January 5, 2021 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brimoor brimoor brimoor approved these changes

Assignees

@benjaminpkane benjaminpkane

Labels
app Issues related to App features bug Bug fixes server Issues related to server features or changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Field stats don't load on empty views
2 participants
@benjaminpkane @brimoor