New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI updates and styles #76
Conversation
@lethosor @tylerganter Can one of you get this reviewed? We need to merge this ASAP. The walkthrough today needs to be on |
There also doesn't appear to be a gunicorn process running. |
Got a backtrace from the server:
This might be a setup issue on my end; investigating |
Looks like for local dev, you currently need to run |
|
||
atexit.register(handle_exit) | ||
signal.signal(signal.SIGTERM, handle_exit) | ||
signal.signal(signal.SIGINT, handle_exit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intercepting SIGINT breaks the ctrl-c behavior in the python
interpreter (i.e. pressing ctrl-c does nothing to the current line at all, and also kills services, which I don't think is desirable).
Also worth noting that only one signal handler can be registered for a signal at a time, so this will only work for one service. Is atexit not enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confirmed that something on this branch is breaking the prod build of the app (and was the cause of the inability to package this on Friday), even when develop
is merged in. Unsure exactly why yet, as dev tools being disabled (prematurely?) in #47 make this somewhat harder to troubleshoot, but I will continue investigating.
Prod build on develop (yarn package-linux
then ./release/FiftyOne-1.1.0.AppImage
):
Prod build on this branch (before and after develop is merged in, and run a few times to make sure it's not only an intermittent issue):
Was previously only giving a white screen (#76) Ref: electron-react-boilerplate/electron-react-boilerplate#2434 (comment)
9128e6b seems to have fixed the issue, at least on this branch and when Update: prod GUI launches on both Linux and macOS, looking like this: |
Thanks @lethosor! The builds are working for me now. Ready to merge if you are. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, sounds good to me
Adding support for sorting patches views by similarity
To be reviewed and merged after #55 and #75.
Resolves #62.
Be sure to initialize the
player51
submodule.And run
yarn install
in./electron
.Possible TODOs:
Fields
tab