Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire event when everything is loaded and player is really ready #41

Open
jasoncorso opened this issue Jun 18, 2019 · 2 comments
Open

Fire event when everything is loaded and player is really ready #41

jasoncorso opened this issue Jun 18, 2019 · 2 comments
Labels
enhancement Code enhancement feature Work on a feature request

Comments

@jasoncorso
Copy link
Contributor

User request to have an event fired when all data is loaded from the server and video can really begin playing (with annotations).

@jasoncorso jasoncorso added enhancement Code enhancement feature Work on a feature request labels Jun 18, 2019
@benjaminpkane
Copy link
Contributor

benjaminpkane commented Feb 10, 2020

Bump. Labels are not rendering for single frame media fragments. These asynchronous calls I've linked below are likely part of the problem. I will look into this more when time permits. Labels are being flagged as processed after issuing the asynchronous functions. There is no guarantee that the labels are actually loaded with the current approach.

waitUntil(() => (typeof(this.canvasWidth) != 'undefined' &&

waitUntil(() => (typeof(this.canvasWidth) != 'undefined' &&

The following labels will not be rendered when given the clip range [0, 0].

{
    "filename": "sample.mp4",
    "frames": {
        "1": {
            "frame_number": 1,
            "objects": {
                "objects": [
                    {
                        "label": "vehicle",
                        "bounding_box": {
                            "top_left": {
                                "x": 0.5090277777777777,
                                "y": 0.49027777777777776
                            },
                            "bottom_right": {
                                "x": 0.5506944444444445,
                                "y": 0.5666666666666667
                            }
                        },
                        "index": 1,
                        "frame_number": 1,
                        "attrs": {
                            "attrs": [
                                {
                                    "type": "eta.core.data.CategoricalAttribute",
                                    "name": "color",
                                    "value": "silver",
                                    "confidence": 1
                                }
                            ]
                        }
                    }
                ]
            }
        }
    }
}

@lethosor
Copy link
Contributor

I'd suggest basing any testing/fixes on the cleanup branch - there are some fixes there for edge conditions, maybe related to that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Code enhancement feature Work on a feature request
Projects
None yet
Development

No branches or pull requests

3 participants