Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple Rubocop warnings #106

Merged
merged 3 commits into from
Mar 26, 2023
Merged

Fix multiple Rubocop warnings #106

merged 3 commits into from
Mar 26, 2023

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak self-assigned this Mar 24, 2023
@bastelfreak bastelfreak changed the title Rubocop Fix multiple Rubocop warnings Mar 24, 2023
@codecov
Copy link

codecov bot commented Mar 24, 2023 •
edited
Loading

Codecov Report

Patch coverage: 75.00% and no project coverage change.

Comparison is base (520d50e) 85.61% compared to head (01af4be) 85.61%.

❗ Current head 01af4be differs from pull request most recent head d5e7f10. Consider uploading reports for the commit d5e7f10 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   85.61%   85.61%           
=======================================
  Files           1        1           
  Lines         292      292           
=======================================
  Hits          250      250           
  Misses         42       42
Impacted Files Coverage Δ
lib/beaker/hypervisor/docker.rb 85.61% <75.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

jay7x
jay7x reviewed Mar 25, 2023
View reviewed changes
Copy link
Member

@jay7x jay7x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to drop Metric cops as those are disabled in .rubocop.yml anyway

@jay7x jay7x mentioned this pull request Mar 25, 2023
Merged
smortex
smortex approved these changes Mar 25, 2023
View reviewed changes
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bastelfreak
Copy link
Member Author

@jay7x I disabled the Metrics cop

@bastelfreak bastelfreak merged commit 135b8fe into voxpupuli:master Mar 26, 2023
@bastelfreak bastelfreak deleted the rubocop branch March 26, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

@jay7x jay7x jay7x approved these changes

Assignees

@bastelfreak bastelfreak

Labels
None yet
Projects
Implement Ruby 3.2 support
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastelfreak @smortex @jay7x