Don't set container name to node hostname

[jovrum]

As pointed out here, PR #3 introduced a regression by setting the container name to the node hostname by default. This prevents running beaker concurrently with other beaker nodesets containing nodes with the same hostname.

This patch simply leaves that option blank by default (pre-PR3 behavior).

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[ekohl]

I can verify that the issue and that applying this patch fixes it.

[mchllweeks]

@jovrum Please add a test so we can ensure we don't break this again in the future.

[ekohl]

An interesting point could be to enable reusing containers with BEAKER_provision=no which the fixed name could help with but I've never been able to successfully use that with beaker-docker.

[jovrum]

@ekohl, FWIW, you can set docker_container_name in the node definition to get a fixed name.

[jovrum]

@mchllweeks, I amended the commit to fix the tests, but ideally there should be an explicit test of the absence of the 'name' parameter (except for the 'docker_container_name' test), with a comment explaining why.

Any rspec veterans know of a clean way to do that here?

[ekohl]

would adding .without('name') work?

[jovrum]

@ekohl, where?

[ekohl]

I tried my suggestion but it doesn't work so I'm out of ideas.

[ferglor]

@jovrum is hash_excluding what you want? https://github.com/rspec/rspec-mocks listed under "Argument Matchers" in the README

[mchllweeks]

last comment still current

[jovrum]

@ferglor, thanks! Updated the test to use hash_excluding.

[mchllweeks]

@puppetlabs-jenkins retest this please