-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Rubocop #72
Enable Rubocop #72
Conversation
Codecov ReportBase: 84.74% // Head: 84.74% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
=======================================
Coverage 84.74% 84.74%
=======================================
Files 1 1
Lines 295 295
=======================================
Hits 250 250
Misses 45 45 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should consider fixing various cops rather than building up a huge todo file. And we should consider moving to Ruby 2.5+ at least.
Cops are mostly disabled now to make the lint stage pass.
@ekohl I think we currently imply ruby 2.4 support. It's not mentioned in the gemspec, but we test on it in CI, and most other beaker gems claim ruby 2.4 support. should we merge this as is, do a minor release and then bump to ruby 2.5? We could also wait with the bump until Puppet 6 is EoL in January? and then directly bump to 2.7. Or we directly bump to 2.7. I don't see a requirement for beaker to match the ruby versions in Puppet AIO packages. We also don't have that as a CI requirement. Edit: beaker-hcloud is the latest/newest beaker gem and it started with Ruby 2.7 as a requirement, but we could change that, it's not yet released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a quick look at the violations, but a LOT are layout ones so I'd be OK with leaving those for a future PR.
This PR enables
rubocop
in the GHA. Though all cops are disabled at the moment in the.rubocop_todo.yml
file.