Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused rspec-its dependency #98

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Mar 17, 2023

Includes #97 to avoid a merge conflict later on.

We still need to allow version < 1.9 for Ruby < 2.7 support.
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (33f9b3c) 84.74% compared to head (b69ec3a) 84.74%.

❗ Current head b69ec3a differs from pull request most recent head 1ccdd66. Consider uploading reports for the commit 1ccdd66 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   84.74%   84.74%           
=======================================
  Files           1        1           
  Lines         295      295           
=======================================
  Hits          250      250           
  Misses         45       45           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bastelfreak bastelfreak merged commit 4a2e6ad into voxpupuli:master Mar 17, 2023
@ekohl ekohl deleted the drop-unused-rspec-its branch March 17, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants