remove audio of SUT with virtualbox

[Dan33l]

Some circumstances (not identified) cause Beaker runs to stop with following error message :

daneel:/tmp/puppet-virtualbox$ RBENV_VERSION=2.5.1 BEAKER_IS_PE=no PUPPET_INSTALL_TYPE=agent BEAKER_PUPPET_COLLECTION=puppet5 BEAKER_debug=yes bundle exec rake beaker:ubuntu-server-1804-x64
[... 8x ...]
Hypervisor for ubuntu-server-1804-x64 is vagrant
Beaker::Hypervisor, found some vagrant boxes to create
created Vagrantfile for VagrantHost ubuntu-server-1804-x64
Bringing machine 'ubuntu-server-1804-x64' up with 'virtualbox' provider...
==> ubuntu-server-1804-x64: Importing base box 'ubuntu/bionic64'...
Progress: 10%Progress: 90%==> ubuntu-server-1804-x64: Matching MAC address for NAT networking...
==> ubuntu-server-1804-x64: Checking if box 'ubuntu/bionic64' is up to date...
==> ubuntu-server-1804-x64: A newer version of the box 'ubuntu/bionic64' for provider 'virtualbox' is
==> ubuntu-server-1804-x64: available! You currently have version '20180717.1.0'. The latest is version
==> ubuntu-server-1804-x64: '20181114.1.0'. Run `vagrant box update` to update.
==> ubuntu-server-1804-x64: Setting the name of the VM: ubuntu-server-1804-x64yml_ubuntu-server-1804-x64_1542707627432_97414
==> ubuntu-server-1804-x64: Clearing any previously set network interfaces...
==> ubuntu-server-1804-x64: Preparing network interfaces based on configuration...
    ubuntu-server-1804-x64: Adapter 1: nat
    ubuntu-server-1804-x64: Adapter 2: hostonly
==> ubuntu-server-1804-x64: Forwarding ports...
    ubuntu-server-1804-x64: 22 (guest) => 2222 (host) (adapter 1)
==> ubuntu-server-1804-x64: Running 'pre-boot' VM customizations...
==> ubuntu-server-1804-x64: Booting VM...

An error occurred while loading ./spec/acceptance/01_virtualbox_spec.rb.
Failure/Error: require 'beaker-rspec'
RuntimeError:
  Failed to exec 'vagrant up'. Error was There was an error while executing `VBoxManage`, a CLI used by Vagrant
  for controlling VirtualBox. The command and stderr is shown below.
  
  Command: ["startvm", "a05bd452-ca6e-47cf-8b0c-0ac749d58b89", "--type", "headless"]
  
  Stderr: VBoxManage: error: The specified string / bytes buffer was to small. Specify a larger one and retry. (VERR_CFGM_NOT_ENOUGH_SPACE)
  VBoxManage: error: Details: code NS_ERROR_FAILURE (0x80004005), component ConsoleWrap, interface IConsole

It looks to be a bug in Virtualbox/VBoxManage. But, removing audio from SUT is enough to workaround. And IMO sound is not used on SUT during acceptance tests.

Can you consider to include this PR ?

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[Dan33l]

Hi, @smcelmurry . Can you have a look ?

[mattkirby]

Will this change work for all platforms? I think it seems like a reasonable assessment that audio is unlikely to be used during the course of running a beaker test. One thing that's not clear to me is what happens if a platform does not support this option. Also, how often does this failure occur for you?
Can you please consider filing a bug ticket for this? https://tickets.puppetlabs.com/issues/?jql=project%20%3D%20BKR

[Dan33l]

I tested only with ubuntu. But all linux should be able to support this option since all linux support audio. For others platforms i don't know.

I meet this issue only with box ubuntu/bionic64 and some versions of virtualbox.

What is the link between this issue and the jira Beaker / BKR-1559 issue with title Wrong PATH substitution pushed to environment?

[kevpl]

@Dan33l please make these contributor changes & then we'll look to pushing this through towards merging:

• please pre-pend your git commit message with either (MAINT) or a beaker ticket reference
• please add a spec test so that we don't break your fix in the future

Matt wasn't referencing BKR-1559 specifically, he was pointing to the BKR Jira project, that just happened to be the top result at the time.

[Dan33l]

@kevpl it should be done.
Tell me if what i did is what your expected.