Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop: Fix more Style cops #1792

Merged
merged 8 commits into from
Mar 24, 2023
Merged

Conversation

bastelfreak
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage: 73.33% and no project coverage change.

Comparison is base (db9f103) 74.65% compared to head (f1dfc34) 74.65%.

❗ Current head f1dfc34 differs from pull request most recent head f884a91. Consider uploading reports for the commit f884a91 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1792   +/-   ##
=======================================
  Coverage   74.65%   74.65%           
=======================================
  Files          81       81           
  Lines        4494     4494           
=======================================
  Hits         3355     3355           
  Misses       1139     1139           
Impacted Files Coverage Δ
lib/beaker/dsl/helpers/web_helpers.rb 62.26% <0.00%> (ø)
lib/beaker/host/pswindows/exec.rb 54.05% <0.00%> (ø)
lib/beaker/host/unix/exec.rb 72.13% <0.00%> (ø)
lib/beaker/options/presets.rb 83.78% <ø> (ø)
lib/beaker/tasks/rake_task.rb 0.00% <0.00%> (ø)
lib/beaker/host/windows/exec.rb 56.25% <50.00%> (ø)
lib/beaker/ssh_connection.rb 59.64% <71.42%> (ø)
lib/beaker/test_suite_result.rb 66.07% <80.00%> (ø)
lib/beaker/cli.rb 84.04% <100.00%> (ø)
lib/beaker/dsl.rb 87.50% <100.00%> (ø)
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bastelfreak bastelfreak changed the title rubocop: Enable Metrics cops rubocop: Fix more Style cops Mar 24, 2023
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really used to %w[] and %i[] so I wonder if that's really better or if we should disable the cops for those. Thought I don't feel too strong about it and think it can be merged.

@bastelfreak
Copy link
Member Author

I also don't have a strong opinion about it. My usual rule of thumb is: Follow upstream rubocop as much as possible.

@bastelfreak bastelfreak merged commit 47f0db9 into voxpupuli:master Mar 24, 2023
@bastelfreak bastelfreak deleted the rubocop branch March 24, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants