-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rubocop: Fix more Style cops #1792
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1792 +/- ##
=======================================
Coverage 74.65% 74.65%
=======================================
Files 81 81
Lines 4494 4494
=======================================
Hits 3355 3355
Misses 1139 1139
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really used to %w[]
and %i[]
so I wonder if that's really better or if we should disable the cops for those. Thought I don't feel too strong about it and think it can be merged.
I also don't have a strong opinion about it. My usual rule of thumb is: Follow upstream rubocop as much as possible. |
No description provided.