Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance documentation about roles #1800

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Conversation

rwaffen
Copy link
Sponsor Member

@rwaffen rwaffen commented Apr 5, 2023

if one does not set any role, you get an error

     Failure/Error: it { is_expected.to be_installed }
     Beaker::DSL::Outcomes::FailTest:
       There should be one host with default defined!

One and only one is allowed to be default.

Failure/Error: configure_beaker
ArgumentError:
  Only one host may have the role 'default', default roles assigned to [:"ubuntu-20-04", :"ubuntu-18-04", :"ubuntu-22-04"]

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c00e1be) 74.65% compared to head (c2caef8) 74.65%.

❗ Current head c2caef8 differs from pull request most recent head 49735b2. Consider uploading reports for the commit 49735b2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1800   +/-   ##
=======================================
  Coverage   74.65%   74.65%           
=======================================
  Files          81       81           
  Lines        4494     4494           
=======================================
  Hits         3355     3355           
  Misses       1139     1139           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this isn't exactly true. AFAIK roles are mandatory on multi-host setups, but optional on single host setups.

@rwaffen
Copy link
Sponsor Member Author

rwaffen commented Apr 6, 2023

ah okay. makes sense. in my single host setup it worked until i changed it to multihost. then i try to put this somehow into a sentence. 🤔

@rwaffen rwaffen requested a review from ekohl April 20, 2023 08:06
@bastelfreak
Copy link
Member

@rwaffen please rebase to get rid of the merge commit.

@bastelfreak bastelfreak merged commit 208de04 into voxpupuli:master Apr 21, 2023
@rwaffen rwaffen deleted the update_docu branch April 25, 2023 08:43
@bastelfreak bastelfreak changed the title roles are not optional Enhance documentation about roles Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants