Adds Rocky Linux vagrant image, facts and get_facts.sh support #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoneycutt
reviewed
Jul 20, 2021
ghoneycutt
requested changes
Jul 20, 2021
|
Great job on adding another platform! |
smortex
approved these changes
Jul 20, 2021
|
@smortex like this or did you mean in the Vagrantfile as well? |
I meant Thanks! |
ghoneycutt
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added Rocky Linux support.
The factset is from a local KVM VM, so you'd have to regenerate it with Vagrant. I've added a stanza for Rocky as well, but can't test it.