Rework of Lots of Puppet 5 facter additions #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matches: CentOS release 6.6 (Final) CentOS Linux release 7.4.1708 (Core)
Normalize Debian 8
…acter 3.9, 3.10 and 3.11 Add Ubuntu 18.04 for Facter 3.11
raphink
reviewed
Dec 11, 2018
facts/Vagrantfile
Outdated
| @@ -7,6 +7,7 @@ VAGRANTFILE_API_VERSION = "2" | |||
| Vagrant.configure(VAGRANTFILE_API_VERSION) do |config| | |||
|
|
|||
| config.vm.hostname = "foo.example.com" | |||
| config.vm.synced_folder ".", "/vagrant", type: "virtualbox" | |||
There was a problem hiding this comment.
What is the goal of syncing the whole dir?
There was a problem hiding this comment.
I don't know the goal of original author.
It should be possible to delete this line.
Do you want me to proceed?
There was a problem hiding this comment.
It looks like this might have been added to perform tests and might not be necessary anymore.
There was a problem hiding this comment.
I pushed a new Vagrantfile in a separate commit since i don't know how to preserve author in this situation.
1 similar comment
|
thank you. |
|
thank you for fixing that 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of original PR #86: