Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IPAddr class to validate ip formats #143

Merged
merged 2 commits into from Oct 26, 2014
Merged

Conversation

RST-J
Copy link
Contributor

@RST-J RST-J commented Oct 26, 2014

This fixes #133 and also uses the IPAddr class to validate ipv4.

pd added a commit that referenced this pull request Oct 26, 2014
Use IPAddr class to validate ip formats
@pd pd merged commit 54b0d9b into voxpupuli:master Oct 26, 2014
@pd
Copy link
Contributor

pd commented Oct 26, 2014

Eek; while wading through the older issues that were still open, I ran across this comment about why IPAddr was avoided: #79 (comment)

@hoxworth what are your thoughts on this? Was it an issue on 1.8.x only? We don't run travis on 1.8 right now; does that mean it's no longer supported?

@iainbeeston
Copy link
Contributor

When I set up Travis I didn't include Ruby 1.8 because (I believe) it's no longer maintained or updated.

@iainbeeston
Copy link
Contributor

Also, if json-schema should be 1.9+ (or 1.8+) we should update the gemspec to say that, explicitly.

@hoxworth
Copy link
Contributor

@pd I'm not as concerned as I used to be over the system callout for IPAddr.new - I'd much rather use the built-in libraries, and I am comfortable moving to the built-in libraries at this point, even for 1.8.7. I'd like to maintain compatibility with 1.8.7 at the very least, as there are still some people using that version, but certain capabilities are starting to make me want to drop 1.8x support...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in IPV6 format validation
4 participants