Add 1.8.7 minimum ruby version to the spec #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Could we also add "jruby-18mode" and "1.8.7" to |
|
Will do, we'll see how the build handles it. |
|
Yeah, 1.8.7 build failed due to a default JSON lib not being installed. Will remove the travis commit for now until I have time to make Travis do my bidding. |
This reverts commit 9ff2f50.
|
No worries. I'm happy to fix that up in a separate pull request. |
|
I've opened #154 for travis. Otherwise I can't see why we shouldn't merge this. |
Merged
|
Let's merge this. |
iainbeeston
added a commit
that referenced
this pull request
Oct 28, 2014
Add 1.8.7 minimum ruby version to the spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested in #143