Restricted the ruby 1.9 build to json < 2 #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 2.0 of the json gem requires ruby 2+. We should continue supporting ruby 1.9, but to do so we need to make sure that travis uses version 1 of the json gem. I've done this by adding a custom gemfile for ruby 1.9 that restricts json to version 1.
|
@RST-J Could I please get a quick code review of this? (Right now the build is broken on master because of a change in the latest version of the json gem) |
|
You can 😃 👍 |
|
@RST-J Great, thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2.0 of the json gem requires ruby 2+. We should continue
supporting ruby 1.9, but to do so we need to make sure that travis uses
version 1 of the json gem.
I've done this by adding a custom gemfile for ruby 1.9 that restricts
json to version 1.