Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable RSpec/MultipleExpectations #658

Merged
merged 1 commit into from Jul 11, 2020

Conversation

alexjfisher
Copy link
Member

This would allow us to upgrade rubocop-rspec to 1.16 without creating a
whole bunch of extra work.

See voxpupuli/voxpupuli-test#26

This would allow us to upgrade rubocop-rspec to 1.16 without creating a
whole bunch of extra work.
@igalic
Copy link
Contributor

igalic commented Jul 11, 2020

it would be nice if rubocop --auto-fix would fix that…

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I think this cop is a nice idea, but multiple expectations have their uses. For example, it's much faster if you don't need to compile the entire catalog again. AFAIK it { } does compile it every time.

@ekohl ekohl merged commit 49b83e7 into voxpupuli:master Jul 11, 2020
@alexjfisher
Copy link
Member Author

In general I think this cop is a nice idea, but multiple expectations have their uses. For example, it's much faster if you don't need to compile the entire catalog again. AFAIK it { } does compile it every time.

... not sure. Maybe not?? I'm not clever enough to understand how rspec puppet catalog caching works. I remember someone looking into this in the past though... rodjek/rspec-puppet#329 ??? ;)

@alexjfisher
Copy link
Member Author

I'm not against the cop per se either. Just at this particular moment didn't want to go create a whole lot of yak shaving just to solve voxpupuli/pdksync_config#1 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants