-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow source to accept absolute file paths #77
Comments
There is some wrapper methods in puppet that might do the job. https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util.rb#L213 |
Yep uri_to_path will do the job here. |
So the idea here would allow the type code to not only accept file urls but also absolute file paths and convert file urls to absolute file paths to be handled by the bodeco util code. This is necessary because windows file urls do not currently convert correctly to absolute paths. So the common format will be absolute paths but continue to support file urls to maintain backwards compatibility. |
I've filed #122 to start looking at this. |
This also allows local files to be specified without using file:///
This also allows local files to be specified without using file:///
This also allows local files to be specified without using file:///
This also allows local files to be specified without using file:///
This also allows local files to be specified without using file:///
This also allows local files to be specified without using file:///
This also allows local files to be specified without using file:///
* Fix local files for non faraday providers * Fix voxpupuliGH-77 allows local files to be specified without using file:/// * Fix voxpupuliGH-78 allow local file:///c:/... on windows
* Fix local files for non faraday providers * Fix voxpupuliGH-77 allows local files to be specified without using file:/// * Fix voxpupuliGH-78 allow local file:///c:/... on windows
* Fix local files for non faraday providers * Fix voxpupuliGH-77 allows local files to be specified without using file:/// * Fix voxpupuliGH-78 allow local file:///c:/... on windows
Fix several issues related to local files
* Fix local files for non faraday providers * Fix voxpupuliGH-77 allows local files to be specified without using file:/// * Fix voxpupuliGH-78 allow local file:///c:/... on windows
I have been noticing that I constantly have to convert /tmp/some/file.txt to file:///tmp/some/file.txt and would rather just have the type code do this by munging the value.
Any objection to adding support for the source parameter to accept absolute file paths?
The text was updated successfully, but these errors were encountered: