Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow source to accept absolute file paths #77

Closed
logicminds opened this issue Oct 20, 2015 · 4 comments
Closed

allow source to accept absolute file paths #77

logicminds opened this issue Oct 20, 2015 · 4 comments

Comments

@logicminds
Copy link
Contributor

I have been noticing that I constantly have to convert /tmp/some/file.txt to file:///tmp/some/file.txt and would rather just have the type code do this by munging the value.

Any objection to adding support for the source parameter to accept absolute file paths?

@logicminds
Copy link
Contributor Author

@nanliu
Copy link
Contributor

nanliu commented Oct 23, 2015

Yep uri_to_path will do the job here.

@logicminds
Copy link
Contributor Author

So the idea here would allow the type code to not only accept file urls but also absolute file paths and convert file urls to absolute file paths to be handled by the bodeco util code. This is necessary because windows file urls do not currently convert correctly to absolute paths. So the common format will be absolute paths but continue to support file urls to maintain backwards compatibility.

@jyaworski jyaworski mentioned this issue Feb 21, 2016
@jyaworski
Copy link
Member

I've filed #122 to start looking at this.

nanliu added a commit to nanliu/puppet-archive that referenced this issue Feb 24, 2016
This also allows local files to be specified without using file:///
nanliu added a commit to nanliu/puppet-archive that referenced this issue Feb 24, 2016
This also allows local files to be specified without using file:///
nanliu added a commit to nanliu/puppet-archive that referenced this issue Feb 24, 2016
This also allows local files to be specified without using file:///
nanliu added a commit to nanliu/puppet-archive that referenced this issue Feb 24, 2016
This also allows local files to be specified without using file:///
nanliu added a commit to nanliu/puppet-archive that referenced this issue Feb 24, 2016
This also allows local files to be specified without using file:///
nanliu added a commit to nanliu/puppet-archive that referenced this issue Feb 25, 2016
This also allows local files to be specified without using file:///
nanliu added a commit to nanliu/puppet-archive that referenced this issue Feb 25, 2016
This also allows local files to be specified without using file:///
nanliu added a commit to nanliu/puppet-archive that referenced this issue Feb 25, 2016
* Fix local files for non faraday providers
* Fix voxpupuliGH-77 allows local files to be specified without using file:///
* Fix voxpupuliGH-78 allow local file:///c:/... on windows
nanliu added a commit to nanliu/puppet-archive that referenced this issue Feb 25, 2016
* Fix local files for non faraday providers
* Fix voxpupuliGH-77 allows local files to be specified without using file:///
* Fix voxpupuliGH-78 allow local file:///c:/... on windows
nanliu added a commit to nanliu/puppet-archive that referenced this issue Feb 25, 2016
* Fix local files for non faraday providers
* Fix voxpupuliGH-77 allows local files to be specified without using file:///
* Fix voxpupuliGH-78 allow local file:///c:/... on windows
jyaworski added a commit that referenced this issue Feb 25, 2016
Fix several issues related to local files
cegeka-jenkins pushed a commit to cegeka/puppet-archive that referenced this issue Oct 23, 2017
* Fix local files for non faraday providers
* Fix voxpupuliGH-77 allows local files to be specified without using file:///
* Fix voxpupuliGH-78 allow local file:///c:/... on windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants