-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pam provider ignores password-auth #105
Conversation
I was having a similar problem where I would reference service => password-auth and the change would go in system-auth. I got around it by specify the full path to the target file:
|
Did not help, unfortunately. password-auth file remains untouched. Also puppet agent --test --debug does not appear to show any information about pam being ran at all. |
I can confirm this bug, although in my case, it behaves slightly differently: $ puppet apply ticket_105.pp
notice: /Stage[main]//Pam[Add radius authentication password-auth]/ensure: created
notice: Finished catalog run in 0.26 seconds actually created (I'm using a fakeroot) auth sufficient pam_radius_auth.so try_first_pass localifdown conf=/etc/sysconfig/raddb client_id=tacacs |
If I comment either of the resources, I get the exact same result, so it seems that the provider sees them as exactly equivalent. |
Forcing the |
I've attached a commit to this ticket. Could you check if the attached branch fixes the bug for you please? |
Interestingly enough, forcing the target did nothing on my system. I'll try the patch once travis is happy. |
Rspec 3 was just released. The Travis errors come from this ( |
My bad, it's actually my code that fails. Travis is running again. |
This seems to work. |
Fixed in 42ea31c |
@domcleal Do you want to merge this into the 1.X branch? |
@raphink er, you've already merged it to master, so it's a bit late. I guess I'll cherry pick to do a 1.1, else we'd have to revert, merge to a stable branch and then merge through to master again. |
I was thinking of a cherry-pick. What would be your preferred way of doing it? |
Cherry pick's fine, I'll do it nearer the time. The other way of doing it is to commit to the stable branch first and merge that into master, but I don't much care. |
I have configuration like this
For some strange reason, it only applies system-auth, and ignores password-auth
completely. I cannot see anything in logs about it. If I change system-auth, it will repair the settings, but not for password-auth.