-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grub2 does not add the /files/etc/default/grub/GRUB_CMDLINE_LINUX_DEFAULT path if it is missing #11
Comments
Good catch it seems. Could you try to provide tests for this? |
Here you go: https://github.com/trevor-vaughan/grub_test bundle |
OK. I would have preferred a PR adding a test to this module instead of external code. |
Fair enough. Are you OK with the approach that I used in that link? I can port it in, just not for a few days. |
Take your time. I'm afk for another 10 days, can't really thoroughly review from my phone. |
* Ensure that any missing element is created before attemping to be modified. This prevents Augeas failures. * Copy GRUB_CMDLINE_LINUX to GRUB_CMDLINE_LINUX_DEFAULT if the latter does not exist. * Added Beaker tests to cover these two cases and allow for further practical expansion. Fixes voxpupuli#11
* Ensure that any missing element is created before attemping to be modified. This prevents Augeas failures. * Copy GRUB_CMDLINE_LINUX to GRUB_CMDLINE_LINUX_DEFAULT if the latter does not exist. * Added Beaker tests to cover these two cases and allow for further practical expansion. Fixes voxpupuli#11
* Ensure that any missing element is created before attemping to be modified. This prevents Augeas failures. * Copy GRUB_CMDLINE_LINUX to GRUB_CMDLINE_LINUX_DEFAULT if the latter does not exist. * Added Beaker tests to cover these two cases and allow for further practical expansion. Fixes voxpupuli#11
* Ensure that any missing element is created before attemping to be modified. This prevents Augeas failures. * Copy GRUB_CMDLINE_LINUX to GRUB_CMDLINE_LINUX_DEFAULT if the latter does not exist. * Added Beaker tests to cover these two cases and allow for further practical expansion. Fixes voxpupuli#11
* Ensure that any missing element is created before attemping to be modified. This prevents Augeas failures. * Copy GRUB_CMDLINE_LINUX to GRUB_CMDLINE_LINUX_DEFAULT if the latter does not exist. * Added Beaker tests to cover these two cases and allow for further practical expansion. Fixes voxpupuli#11
Attempted to apply the following with Puppet:
Received the following error:
This appears to be because GRUB_CMDLINE_LINUX_DEFAULT is not present in /etc/default/grub by default and should be created by Augeas if it is not present in the file.
Ideally, it would default to whatever GRUB_CMDLINE_LINUX has in it at the time of creation.
The text was updated successfully, but these errors were encountered: