Fix GRUB_CMDLINE_LINUX_DEFAULT #14
Merged
+153
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensure that any missing element is created before attemping to be modified. This prevents Augeas failures. * Copy GRUB_CMDLINE_LINUX to GRUB_CMDLINE_LINUX_DEFAULT if the latter does not exist. * Added Beaker tests to cover these two cases and allow for further practical expansion. Fixes voxpupuli#11
|
What is the added value of acceptance tests in this case? |
|
The main value of the acceptance tests is that it's testing the actuality of the system. If there is a change in Grub that would cause an issue in the future, then this can be caught early instead of discovering the issue in the field. Also, frankly, we're finding acceptance tests to be more accurate and easier for most people to maintain than traditional spec tests. |
raphink
added a commit
that referenced
this pull request
Feb 18, 2016
Fix GRUB_CMDLINE_LINUX_DEFAULT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified. This prevents Augeas failures.
does not exist.
practical expansion.
Fixes #11