Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate CONTRIBUTING.md file #30

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Remove duplicate CONTRIBUTING.md file #30

merged 1 commit into from
Nov 29, 2019

Conversation

dhoppe
Copy link
Member

@dhoppe dhoppe commented Nov 29, 2019

No description provided.

@ekohl
Copy link
Member

ekohl commented Nov 29, 2019

I wonder if we should set this via modulesync:

CONTRIBUTING.md:
  delete: true

@ekohl ekohl merged commit 0c94805 into voxpupuli:master Nov 29, 2019
@dhoppe
Copy link
Member Author

dhoppe commented Nov 29, 2019

@ekohl I had the same idea, but I did not want to inflate modulesync unnecessarily. Also, I already covered almost all modules.

@ekohl
Copy link
Member

ekohl commented Nov 29, 2019

You could also use modulesync to do it all but not commit. I've used msync update --offline to do the patches and then some shell loops around it to submit PRs.

@dhoppe
Copy link
Member Author

dhoppe commented Nov 29, 2019

@ekohl That would definitely have been the more intelligent solution. ;)

@ekohl
Copy link
Member

ekohl commented Nov 29, 2019

A typical loop I'd use is:

for mod in modules/*/puppet-* ; do
  ( cd $mod && git add CONTRIBUTING.md && git co -b remove-duplicate-contributing && git commit -m '[skip ci] Remove duplicate CONTRIBUING.md' && git push --quiet $REMOTE HEAD && hub pull-request -m 'Remove duplicate CONTRIBUTING.md' )
done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants