Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Sensitive #86

Merged
merged 1 commit into from Nov 7, 2021
Merged

Allow Sensitive #86

merged 1 commit into from Nov 7, 2021

Conversation

arjenz
Copy link
Member

@arjenz arjenz commented Nov 5, 2021

Pull Request (PR) description

Also allow Sensitive contents (might contain md5 shared keys for instance).

This Pull Request (PR) fixes the following issues

kenyon
kenyon requested changes Nov 5, 2021
View reviewed changes
Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please give the commit message a better title, like snippet: allow Sensitive content? That way we can quickly know what part of the module this commit is about.

@kenyon kenyon added the enhancement New feature or request label Nov 5, 2021
@arjenz
snippet: Allow Sensitive data
799ab95 
Allow Sensitive data to be passed into bird::snippet. Useful for passing
md5 shared keys for example
@arjenz
Copy link
Member Author

arjenz commented Nov 5, 2021

Can you please give the commit message a better title, like snippet: allow Sensitive content? That way we can quickly know what part of the module this commit is about.

Of course!

@arjenz arjenz requested a review from kenyon November 6, 2021 11:14
@b4ldr b4ldr merged commit 5275bc3 into voxpupuli:master Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyon kenyon kenyon approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arjenz @kenyon @b4ldr