Use Caddy 2.x syntax #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CentOS 6 is EOL so testing it is no longer possible. Since this module contains actual code to be compatible with it, that's removed now. As such, RHEL 6 support is also dropped.
This appears to have changed
CI shows that the module configure caddy with unsupported settings and pass unsupporte command line arguments to the daemon. These where legacy settings / options that got deprecated with Caddy 2.x and are no removed. Adjust the produced config so that it is valid in regard of the current configuration specification, and fix the cli arguments to match what is currently supported. This fix acceptance tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing examples where updated following instructions from: https://caddyserver.com/docs/v2-upgrade
This also include:
Fixes #34
Fixes #66