Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modulesync 4.0.0 & puppet-lint updates #73

Merged
merged 16 commits into from
Jul 9, 2023
Merged

modulesync 4.0.0 & puppet-lint updates #73

merged 16 commits into from
Jul 9, 2023

Conversation

bastelfreak
Copy link
Member

modulesync 3.0.0

@vox-pupuli-tasks
Copy link

Dear @bastelfreak, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@bastelfreak bastelfreak changed the title modulesync 3.0.0 & puppet-lint updates modulesync 3.1.0 & puppet-lint updates Oct 24, 2020
@ekohl ekohl changed the title modulesync 3.1.0 & puppet-lint updates modulesync 4.0.0 & puppet-lint updates Nov 25, 2020
@ekohl ekohl removed the tests-fail label Nov 25, 2020
ekohl
ekohl requested changes Nov 25, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloads fail in acceptance tests:

  Error: Execution of '/opt/puppetlabs/puppet/bin/curl https://caddyserver.com/download/linux/amd64?plugins=http.git,http.filter,http.ipfilter&license=personal&telemetry=off -o /tmp/caddy_linux_amd64_custom.tar.gz_20201125-1016-16dplej -fsSLg --max-redirs 5' returned 22: curl: (22) The requested URL returned error: 404 Not Found

@ekohl ekohl force-pushed the modulesync branch 3 times, most recently from b350884 to 5854cd9 Compare December 14, 2020 22:36
@ekohl
Copy link
Member

ekohl commented Dec 14, 2020

I gave it a serious stab, but now also the systemd file needs to be updated to match https://github.com/caddyserver/dist/blob/master/init/caddy.service. I don't know caddy, but at least this module appears to be completely broken with the latest version.

@dhoppe do you plan to work on this module or should we retire it?

@kenyon kenyon mentioned this pull request Apr 9, 2021
Merged
@vox-pupuli-tasks
Copy link

Dear @bastelfreak, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@smortex smortex marked this pull request as draft July 9, 2023 19:47
@smortex smortex force-pushed the modulesync branch 5 times, most recently from 1a91fd9 to 6fed7cb Compare July 9, 2023 21:42
@smortex smortex marked this pull request as ready for review July 9, 2023 21:45
This was referenced Jul 9, 2023
Merged
Merged
@smortex smortex merged commit 6fed7cb into master Jul 9, 2023
6 of 18 checks passed
@smortex smortex deleted the modulesync branch July 9, 2023 23:14
@smortex smortex mentioned this pull request Jul 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl requested changes

Assignees
No one assigned
Labels
modulesync tests-fail
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bastelfreak @ekohl @smortex @dhoppe @trevor-vaughan @maxadamo