Add Ubuntu 18.04 support #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly needed because openjdk-7-jre-headless isn't available on Ubuntu 18.04 - everything else is the same as for Debian, but I've laid the groundwork for more comprehensive Ubuntu support if it's required. Currently warns you that Ubuntu 18.04 support is experimental
This reverts commit 8a027ca.
bastelfreak
reviewed
Dec 21, 2018
bastelfreak
reviewed
Dec 21, 2018
|
Hey @paulseward, thanks for the PR! Please have a look at the inline comments I made. |
This reverts commit 881ef07.
|
@bastelfreak Thanks for reviewing! I think I've resolved everything you brought up, let me know if there's anything I missed :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add Ubuntu 18.04 support, the main difference to existing ubuntu support is that
openjdk-7-jre-headlessisn't readily available on 18.04 without adding extra repos, so I've bumped that toopenjdk-8-jre-headlessUnit tests appear to pass ok.
I've attempted to add an acceptance test for ubuntu18.04, based off the 16.04 test, although I'm having difficulty getting any of the acceptance tests to pass locally - even when run against the upstream master, so I think that's a problem with my local setup rather than the tests.
This Pull Request (PR) fixes the following issues
Fixes #441