Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for maxdistance #122

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Add support for maxdistance #122

merged 1 commit into from
Jul 12, 2021

Conversation

hoffie
Copy link
Contributor

@hoffie hoffie commented Jul 12, 2021

Pull Request (PR) description

This PR adds support for the maxdistance config option which sets the maximum root distance of a source to be acceptable for synchronisation of the clock and may be required in certain setups (some Windows NTP Servers).

This Pull Request (PR) fixes the following issues

I did not find an existing issue for this feature and did not open one as the PR is low-effort and seems straight-forward.

manifests/config.pp Outdated Show resolved Hide resolved
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, looks like a lot of variables are duplicated in the module. I'll try to fix this in a PR.

If the line I commented above does not serve a specific purpose, please remove it from this PR to avoid conflicts 😉

@smortex
Copy link
Member

smortex commented Jul 12, 2021

I opened this to fix the duplicate variables issue:

@hoffie
Copy link
Contributor Author

hoffie commented Jul 12, 2021

Thanks for the quick review.

If the line I commented above does not serve a specific purpose, please remove it from this PR to avoid conflicts wink

I was just following the pattern of all the other config options. Obviously, it's not needed as the tests confirm. I've removed the addition and force-pushed.

Might have been a left-over from the erb -> epp transition in b971db0 where locally-scoped variables might have been needed?

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might have been a left-over from the erb -> epp transition in b971db0 where locally-scoped variables might have been needed?

I think you are right.

That looks great to me!

@smortex smortex merged commit 779bf89 into voxpupuli:master Jul 12, 2021
@alexjfisher alexjfisher added the enhancement New feature or request label Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants