Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Under Debian, does not update collectd-core when require => 'latest' #269

Closed
rymndhng opened this issue Jun 8, 2015 · 6 comments
Closed

Comments

@rymndhng
Copy link

rymndhng commented Jun 8, 2015

If you're trying to perform an upgrade on an existing collectd installation and set require => 'latest', collectd-core does not get updated.

I would argue that this is more of an issue on the Debian side not specifying version requirements for collectd-core but it'd be great if this module would abstract this problem away.

@txaj
Copy link

txaj commented Jun 9, 2015

Could you give us a complete snippet to reproduce ? Aren't you looking to set latest here instead ? https://github.com/pdxcat/puppet-module-collectd/blob/1830403421c03c10a00552075e164214e97c86da/manifests/init.pp#L16

@rymndhng
Copy link
Author

rymndhng commented Jun 9, 2015

On initial apply of puppet manifest, it works fine.

It doesn't work properly when performing an upgrade on an existing collectd installation:

  1. run puppet with collectd resource with parameter require => 'latest'.
    (This will download the latest version of collectd and collectd-core)
  2. new version of collectd is released
  3. re-run puppet
    (updates collectd but not collectd-core)

@txaj
Copy link

txaj commented Jun 10, 2015

Well...

# apt-cache show collectd|grep Depends
Depends: collectd-core, iptables, libc6 (>= 2.4), librrd4 (>= 1.3.0)

Is the mismatch between collectd and collectd-core causing issues ? If yes I'd also recommend to send this to Debian instead... Other than that I found unpractical to use ensure => latest anyway as it can cause surprise unplanned upgrades...

@rymndhng
Copy link
Author

Yeah, I understand where you're coming from. In our setup we had ensure => 'installed', but on decision to use this module to update to the latest version, it's behavior did not match the expectation.

What I mean is that why have ensure => 'latest' if it's functionality is broken (albeit I haven't tried other platforms, hopefully they don't have this issue as well). I've filed a ticket upstream.

What are your thoughts on patching this inside the collectd module while this gets resolved though, because without managing the collectd-core package currently on Debian, ensure => 'latest' is broken.

@jyaworski
Copy link
Member

I'd rather not have us code around OS packaging problems. However, we could ensure an array of packages on (I assume) $::osfamily == 'Debian'.

@jyaworski
Copy link
Member

Let me know if #406 solves this for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants