processes-config.conf file is not created #926

traylenator · 2020-03-23T17:41:33Z

Affected Puppet, Ruby, OS and module versions/distributions

Puppet: 6.14.0
Ruby:
Distribution: CentoS 7
Module version: 11.3.1-rc0
Collectd version 5.8.1

How to reproduce (e.g Puppet code you use)

collectd::plugin::processes::processmatch{'eosd':
      collect_file_descriptor => true,
      collect_memory_maps     => true,
      collect_context_switch  => false,
      regex => 'eosd .*$',
    }

Apply manifest.

What are you seeing

The file /etc/collectd.d/processes-config.conf is not created.

What behaviour did you expect instead

The file should I think be created with, certainly the metrics are not enabled.

<Plugin processes>
      <ProcessMatch "eosd" "eosd .*$">
        CollectContextSwitch false
        CollectFileDescriptor true
        CollectMemoryMaps true
      </ProcessMatch>
    </Plugin>

Output log

Running puppet agent -d | grep Proces on above manifest.

 puppet apply /test.pp  -d  --color false | grep lugin::Proc    
Debug: Scope(Class[Collectd::Plugin::Processes]): Retrieving epp template collectd/plugin/processes-header.conf.epp
Debug: Scope(Collectd::Plugin::Processes::Processmatch[eosd]): Retrieving epp template collectd/plugin/processes/processmatch.conf.epp
Debug: /Stage[main]/Collectd::Plugin::Processes/Concat[/etc/collectd.d/processes-config.conf]/notify: notify to Service[collectd]
Debug: /Stage[main]/Collectd::Plugin::Processes/Collectd::Plugin[processes]/File[processes.load]/notify: notify to Service[collectd]
Debug: /Stage[main]/Collectd::Plugin::Processes/Collectd::Plugin[processes]/File[older_processes.load]/notify: notify to Service[collectd]
Debug: /Stage[main]/Collectd::Plugin::Processes/Collectd::Plugin[processes]/File[old_processes.load]/notify: notify to Service[collectd]
Debug: /Stage[main]/Collectd::Plugin::Processes/Collectd::Plugin[processes]/File[package_processes.load]/notify: notify to Service[collectd]
Debug: /Stage[main]/Collectd::Plugin::Processes/Concat[/etc/collectd.d/processes-config.conf]/Concat_file[/etc/collectd.d/processes-config.conf]/before: before to File[package_processes.load]
Debug: /Stage[main]/Collectd::Plugin::Processes/Collectd::Plugin[processes]/File[processes.load]: Adding autorequire relationship with File[collectd.d]
Debug: /Stage[main]/Collectd::Plugin::Processes/Collectd::Plugin[processes]/File[older_processes.load]: Adding autorequire relationship with File[collectd.d]
Debug: /Stage[main]/Collectd::Plugin::Processes/Collectd::Plugin[processes]/File[old_processes.load]: Adding autorequire relationship with File[collectd.d]
Debug: /Stage[main]/Collectd::Plugin::Processes/Collectd::Plugin[processes]/File[package_processes.load]: Adding autorequire relationship with File[collectd.d]
Debug: /Stage[main]/Collectd::Plugin::Processes/Concat[/etc/collectd.d/processes-config.conf]/Concat_file[/etc/collectd.d/processes-config.conf]: Skipping automatic relationship with File[package_processes.load]
Debug: /Stage[main]/Collectd::Plugin::Processes/Collectd::Plugin[processes]/File[older_processes.load]: Nothing to manage: no ensure and the resource doesn't exist
Debug: /Stage[main]/Collectd::Plugin::Processes/Collectd::Plugin[processes]/File[old_processes.load]: Nothing to manage: no ensure and the resource doesn't exist
Debug: /Stage[main]/Collectd::Plugin::Processes/Collectd::Plugin[processes]/File[package_processes.load]: Nothing to manage: no ensure and the resource doesn't exist

Any additional information you'd like to impart

Running a git bisect the behaviour changed with

a864d0d

The text was updated successfully, but these errors were encountered:

traylenator · 2020-03-24T08:16:24Z

Hi @paramite

Just deciding how best to fix this, maybe you have some comment?

I see either just change the configuration name that puppet creates away from processes-config.conf
Migrate to 10-proceses.conf to be a concat , stick the fragments in there and then
we only have one file for for plugin which is more beatiful I think. But changing collectd::plugin
has quite some consquences.

traylenator · 2020-03-24T08:21:16Z

The fact that

concat{'/tmp/file':
  ensure => present,
}
concat::fragment{'a snippet':
  content => 'foo',
  target  => '/tmp/file',
}

file{'/tmp/file':
  ensure => absent,
}

is a valid manifest and does not give a compile error is really undesirable.

The above currently purges the file.

alexjfisher · 2020-03-24T09:07:35Z

This isn't much different to how a file_line resource and file resource can conflict though?

There was a name clash between: * Puppet created configuration file. * Package provided configuration file. Since a864d0d the collectd module on RedHat purges the package provided file file `/etc/collectd.d/processes-config.conf` The module was also creating this file with a concat and result was no file on system. To avoid the clash puppet now creates the file `processes_config.conf`. Note the `-` vs `_`. There is probably a cleaner fix to move all of the processes plugin configuration into the per module file `/etc/collect.d/10-processses.conf` as that would be more consistant with other simpler modules. This would be a change for every module however with `collectd::plugin` itself changing. Fixes voxpupuli#926

There was a name clash between: * Puppet created configuration file. * Package provided configuration file which was being purged. Since a864d0d the collectd module on RedHat purges the package provided file file `/etc/collectd.d/processes-config.conf` The module was also creating this file with a concat and result was no file on system. To avoid the clash puppet now creates the file `processes_config.conf`. Note the `-` vs `_`. There is probably a cleaner fix to move all of the processes plugin configuration into the per module file `/etc/collect.d/10-processses.conf` as that would be more consistant with other simpler modules using a single template rather than a concat. This would be a change for every module however with `collectd::plugin` itself changing. Fixes voxpupuli#926

traylenator · 2020-03-24T10:51:09Z

This isn't much different to how a file_line resource and file resource can conflict though?

I think you normally at least see puppet apply doing something in this case, you get an oscillation. With the above there is zero change when puppet apply so long as the file is not there.
Not sure anything can be done, its just easy to fall into.

There was a name clash between: * Puppet created configuration file. * Package provided configuration file which was being purged. Since a864d0d the collectd module on RedHat purges the package provided file file `/etc/collectd.d/processes-config.conf` The module was also creating this file with a concat and result was no file on system. To avoid the clash puppet now creates the file `processes_config.conf`. Note the `-` vs `_`. There is probably a cleaner fix to move all of the processes plugin configuration into the per module file `/etc/collect.d/10-processses.conf` as that would be more consistant with other simpler modules using a single template rather than a concat. This would be a change for every module however with `collectd::plugin` itself changing. Fixes voxpupuli#926

paramite · 2020-03-24T13:22:48Z

I don't understand what is wrong here. IIUC to have the processes-config.conf created you need to use collectd::plugin::processes with appropriate process_matches value, which IIUC you did not use, so it is kind of expected that the config is not created.

traylenator · 2020-03-24T14:09:06Z

I don't understand what is wrong here. IIUC to have the processes-config.conf created you need to use collectd::plugin::processes with appropriate process_matches value, which IIUC you did not use, so it is kind of expected that the config is not created.

Even with process_matches values then processes-config.conf is created as a concat file
but the file resource of absent wins the day.

paramite · 2020-03-24T14:46:47Z

Ah got it. So where does the file resource with absent comes from?

traylenator · 2020-03-25T08:16:31Z

From the commit above: a864d0d

it was added to stop default files form packages interfering.

There was a name clash between: * Puppet created configuration file. * Package provided configuration file which was being purged. Since a864d0d the collectd module on RedHat purges the package provided file file `/etc/collectd.d/processes-config.conf` The module was also creating this file with a concat and result was no file on system. To avoid the clash puppet now creates the file `processes_config.conf`. Note the `-` vs `_`. There is probably a cleaner fix to move all of the processes plugin configuration into the per module file `/etc/collect.d/10-processses.conf` as that would be more consistant with other simpler modules using a single template rather than a concat. This would be a change for every module however with `collectd::plugin` itself changing. Fixes voxpupuli#926

paramite · 2020-03-25T12:41:23Z

@traylenator: Ah, now I understand why you pinged me regarding this :). So if we want to have the processes plugin config name consistent with the rest, then yes rename to something like -processes.conf should be a solution. If we want to keep the name, then probably adding require => File['package_processes.load'] (in combination with defined(File['package_processes.load'])) to the concat and fragments resources should also work, right? I'm not core in this project, so maybe @alexjfisher will show the correct path we should go?

traylenator · 2020-03-25T13:11:32Z

The fix I prefer to this problem of package config vs puppet config is just to avoid the problem and
use say /etc/collectd-puppet/conf.d and ignore the contents of /etc/collectd.d . Works well but a little non standard.

traylenator added the bug Something isn't working label Mar 23, 2020

traylenator mentioned this issue Mar 24, 2020

Create processes plugin configuration on RedHat #927

Merged

bastelfreak closed this as completed in #927 Mar 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

processes-config.conf file is not created #926

processes-config.conf file is not created #926

traylenator commented Mar 23, 2020

traylenator commented Mar 24, 2020

traylenator commented Mar 24, 2020 •

edited

alexjfisher commented Mar 24, 2020 •

edited

traylenator commented Mar 24, 2020

paramite commented Mar 24, 2020

traylenator commented Mar 24, 2020

paramite commented Mar 24, 2020

traylenator commented Mar 25, 2020

paramite commented Mar 25, 2020

traylenator commented Mar 25, 2020

processes-config.conf file is not created #926

processes-config.conf file is not created #926

Comments

traylenator commented Mar 23, 2020

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

What are you seeing

What behaviour did you expect instead

Output log

Any additional information you'd like to impart

traylenator commented Mar 24, 2020

traylenator commented Mar 24, 2020 • edited

alexjfisher commented Mar 24, 2020 • edited

traylenator commented Mar 24, 2020

paramite commented Mar 24, 2020

traylenator commented Mar 24, 2020

paramite commented Mar 24, 2020

traylenator commented Mar 25, 2020

paramite commented Mar 25, 2020

traylenator commented Mar 25, 2020

traylenator commented Mar 24, 2020 •

edited

alexjfisher commented Mar 24, 2020 •

edited