Create processes plugin configuration on RedHat #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traylenator
added
bug
traylenator
force-pushed
the
processes
branch
4 times, most recently
from
1caca48
to
90d5908
Compare
traylenator
changed the title
|
Can't see why this is still pending , leave it a bit to see what happens. |
There was a name clash between: * Puppet created configuration file. * Package provided configuration file which was being purged. Since a864d0d the collectd module on RedHat purges the package provided file file `/etc/collectd.d/processes-config.conf` The module was also creating this file with a concat and result was no file on system. To avoid the clash puppet now creates the file `processes_config.conf`. Note the `-` vs `_`. There is probably a cleaner fix to move all of the processes plugin configuration into the per module file `/etc/collect.d/10-processses.conf` as that would be more consistant with other simpler modules using a single template rather than a concat. This would be a change for every module however with `collectd::plugin` itself changing. Fixes voxpupuli#926
|
Green after an empty rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
There was a name clash between:
Since a864d0d the collectd module on RedHat
purges the package provided file file
/etc/collectd.d/processes-config.confThe module was also creating this file with a concat and result was no
file on system.
To avoid the clash puppet now creates the file
processes_config.conf. Notethe
-vs_.There is probably a cleaner fix to move all of the processes plugin configuration
into the per module file
/etc/collect.d/10-processses.confas that wouldbe more consistant with other simpler modules. This would be a change
for every module however with
collectd::pluginitself changing.This Pull Request (PR) fixes the following issues
Fixes #926