SNMP, filecount and unixsock #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to mention, I'm using the module in Debian 6 and 7, so I have also modified the limitations statement. Cheers. |
| ##Limitations | ||
|
|
||
| This module has been tested on Ubuntu Precise, CentOS 5/6 and Solaris 10. | ||
| This module has been tested on Ubuntu Precise, CentOS 5/6, Solaris 10 and Debian 6/7. |
There was a problem hiding this comment.
Can we get an oxford comma here?
There was a problem hiding this comment.
@jesusaurus do you mean a comma after "Solaris 10" ? If you think it's needed I could try to add it...I was just following the style it was written before I modified it.
There was a problem hiding this comment.
Yes I think thats what he means. @jesusaurus was a linguistics major 
|
This looks terrific! Thanks, if you can just fix the ordering of the plugins then I'll merge. |
|
Does it look better now? 🎉 |
|
Awesome! |
Closed
|
@tripledes Thanks! |
|
@nibalizer no problem! I wanted to PR the changes sooner but lacking time lately ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Added support for SNMP, filecount and unix socket plugins, their tests and modified README.
Also bumped version to >= 3.0.0 for stdlib and fixed source URL in Modulefile.