Modulesync 0.21.3 #672
Merged
Modulesync 0.21.3 #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
changed the title
|
I only wanted to do the rspec-puppet-facts integration, but tests would take way too long without the parallel_tests gem, so I included a modulesync. |
|
blargh |
in general we always want to test against latest master, to catch errors early
bastelfreak
changed the title
|
I pulled most of the changes out into another branch, to make the diff smaller. They are now at #673. I don't think that we can merge this if we want to review all changes properly + have travis green. So we should merge it in parts. |
|
I think this is safe to merge. all the acceptance tests are still green, just unit tests fail because of issues in the puppetlabs-apt modules. This will be addressed in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.