Make it possible to add processes one by one #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a old silent bug that was created by 395036a This commit makes it possible define single process again like: collectd::plugin::processes::process { 'collectd' : } Without also having to create: class { 'collectd::plugin::processes': processes => [ 'foo', 'bar' } This fixes the issues voxpupuli#652 and voxpupuli#595.
|
It would have been possible to create the same affect as 395036a tried to solve by calling the class with ensure => absent . |
|
@oscarkraemer (1) Would it be possible to add test cases to prove that this fixes the issues listed (2) Does the README need to be updated? |
juniorsysadmin
approved these changes
Nov 9, 2017
|
I will not write any new tests, I don't have time. The README should not need any updates since these changes would make the readme correct. |
juniorsysadmin
approved these changes
Dec 2, 2017
This was referenced Dec 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a old silent bug that was created by
395036a
This commit makes it possible define single process again like:
collectd::plugin::processes::process { 'collectd' : }
Without also having to create:
class { 'collectd::plugin::processes':
processes => [ 'foo', 'bar' }
This fixes the issues #652 and #595.