parameterize restart on change for the main config #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aj-jester
force-pushed
the
AJ-restart-on-change
branch
2 times, most recently
from
d725362
to
db47d25
Compare
|
Thanks! |
solarkennedy
added a commit
that referenced
this pull request
Aug 15, 2015
parameterize restart on change for the main config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to restart the agent conditionally when
$config_hashchanges. This does not affect reloads when service, check and watch configs change.It defaults to the current behavior of restarting on config change.
In my experience its never a good idea for puppet to restart consul
server. More often than not you will run into a situation where the cluster doesn't know who the leader is. Its best to restart the agent on server in a more controlled fashion.