Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KV Provider / Prepared Query Bugfixes #294

Merged
merged 2 commits into from
Nov 5, 2016

Conversation

djtaylor
Copy link
Contributor

@djtaylor djtaylor commented Nov 4, 2016

This adds a new KV provider for accessing the Key/Value database API. This also attempts to address issues in the previous Prepared Query PR and the following issues:

@djtaylor djtaylor changed the title KV Provider / Prepared Query Bugfixes [WIP] KV Provider / Prepared Query Bugfixes Nov 4, 2016
@djtaylor
Copy link
Contributor Author

djtaylor commented Nov 4, 2016

Initial testing seems to confirm that the following works:

  • Create a new KV object
  • Update an existing KV object
  • Delete a KV object
  • Handle the 404 when no KV objects exist for the DC

EDIT:

  • Add support for flags parameter w/ default value

Fix syntax issues in prepared query unit test and variable type error
@djtaylor djtaylor changed the title [WIP] KV Provider / Prepared Query Bugfixes KV Provider / Prepared Query Bugfixes Nov 4, 2016
@solarkennedy
Copy link
Contributor

Whoa! Thanks!

@solarkennedy solarkennedy merged commit bfd035c into voxpupuli:master Nov 5, 2016
spuder pushed a commit to spuder/puppet-consul that referenced this pull request Feb 25, 2020
KV Provider / Prepared Query Bugfixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants