make primitive utilization attributes managable #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 13, 2013 12:43
The previous implementation had a lot of duplication of expressions, and pointless creation of nested hashes with only one element only to later unpack them with slightly different keys.
Merged
hunner
added a commit
that referenced
this pull request
Jun 18, 2013
make primitive utilization attributes managable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #40. When implementing this, I found myself doing a lot of dumb copy&paste, and then got a bit carried away on refactoring the existing implementation before I realized I was no longer working on the issue at hand. But, I think the reduction in useless code and improvement in clarity is substantial, so I left it in.