Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ubuntu 18.04, 20.04 and debian 10 support #124

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Add ubuntu 18.04, 20.04 and debian 10 support #124

merged 1 commit into from
Mar 22, 2021

Conversation

traylenator
Copy link
Contributor

@traylenator traylenator commented Mar 18, 2021 •
edited
Loading

Pull Request (PR) description

Add ubuntu 18.04, 20.04 and debian 10 support
Drop puppet 5 support

@traylenator traylenator added the enhancement New feature or request label Mar 18, 2021
@traylenator
Copy link
Contributor Author

@olifre if you could take a look.

@traylenator
Copy link
Contributor Author

@jblomer there is no cvmfs-config repo for debian ?

@traylenator traylenator force-pushed the debian2 branch 2 times, most recently from 6838c0f to 79979ea Compare March 18, 2021 18:16
@traylenator traylenator marked this pull request as ready for review March 18, 2021 18:25
@olifre
Copy link
Contributor

olifre commented Mar 19, 2021

@traylenator That looks good from looking through the code!
Since our infrastructure is not yet on Puppet 6 (@wiene and I are still working on the upgrade), I can not test it on real machines (yet).

One thing I am not sure about is whether people may want to be able to configure
ensure => refreshed
for the key of the apt::source.

I personally believe there is no security risk involved in refreshing, since puppet-apt only does it when the key is actually expired, using existing keyserver infrastructure (see https://github.com/puppetlabs/puppetlabs-apt/blob/8927af46c0bb430be677bc919323c133204a253d/lib/puppet/provider/apt_key/apt_key.rb#L179 ), but it rather saves a lot of hassle in real life. It has saved us in several cases for many repositories when they prolong their keys, which would be either an additional Puppet hack or manual work.

@traylenator
Copy link
Contributor Author

@olifre should still work on puppet 5 , only removed really as no puppet5 avilable for 20.04.

@traylenator
Copy link
Contributor Author

ensure => refreshed on key.

Seems like a bad idea to me, if someone wants they can submit a patch.

@olifre
Copy link
Contributor

olifre commented Mar 19, 2021

@olifre should still work on puppet 5 , only removed really as no puppet5 avilable for 20.04.

@traylenator Indeed, there does not seem to be anything in the code requiring Puppet 6 ;-).
I tested this on a Debian 10 node just now, and it works fine — you also changed the repo URI to https, thanks! 👍

bastelfreak
bastelfreak reviewed Mar 21, 2021
View reviewed changes
data/common.yaml Outdated Show resolved Hide resolved
@traylenator traylenator mentioned this pull request Mar 22, 2021
Merged
bastelfreak
bastelfreak reviewed Mar 22, 2021
View reviewed changes
metadata.json Outdated Show resolved Hide resolved
@traylenator
Add ubuntu 18.04, 20.04 and debian 10 support
675e232 
Add ubuntu 18.04, 20.04 and debian 10 support
Drop puppet 5 support
@traylenator traylenator merged commit b7d174e into voxpupuli:master Mar 22, 2021
traylenator added a commit to traylenator/puppet-cvmfs that referenced this pull request Mar 23, 2021
@traylenator
Release 8.0.0
c9832e3 
**Breaking changes:**

- Remove 'yum' string from class parameters [\voxpupuli#123](voxpupuli#123) ([traylenator](https://github.com/traylenator))
- Add type enforcement to cvmfs::mount and cvmfs::domain [\voxpupuli#122](voxpupuli#122) ([traylenator](https://github.com/traylenator))
- Drop all CvmFS server code [\voxpupuli#113](voxpupuli#113) ([traylenator](https://github.com/traylenator))

**Implemented enhancements:**

- Add CVMFS\_IPFAMILY\_PREFER config parameter [\voxpupuli#125](voxpupuli#125) ([luisfdez](https://github.com/luisfdez))
- Add ubuntu 18.04, 20.04 and debian 10 support [\voxpupuli#124](voxpupuli#124) ([traylenator](https://github.com/traylenator))
- Convert main config template to epp [\voxpupuli#118](voxpupuli#118) ([traylenator](https://github.com/traylenator))

**Fixed bugs:**

- cvmfs\_external\_url parameter to mount fixed [\voxpupuli#127](voxpupuli#127) ([traylenator](https://github.com/traylenator))
- Correct parameter name for default case [\voxpupuli#126](voxpupuli#126) ([traylenator](https://github.com/traylenator))

**Merged pull requests:**

- Update all documentation [\voxpupuli#128](voxpupuli#128) ([traylenator](https://github.com/traylenator))
- Use modern splat rather than create resources [\voxpupuli#121](voxpupuli#121) ([traylenator](https://github.com/traylenator))
- Whitespace, Automatic lint and Rubocop Fixes [\voxpupuli#114](voxpupuli#114) ([traylenator](https://github.com/traylenator))
- Increase upper version of firewall module [\voxpupuli#112](voxpupuli#112) ([sorrison](https://github.com/sorrison))
- cvmfs::install: Fact file creation must depend on Package\[cvmfs\]. [\voxpupuli#111](voxpupuli#111) ([olifre](https://github.com/olifre))
- Add UID\_MAP and GID\_MAP functionality. [\voxpupuli#110](voxpupuli#110) ([olifre](https://github.com/olifre))
- add missing package require for file ownership [\voxpupuli#104](voxpupuli#104) ([fschaer](https://github.com/fschaer))
@traylenator traylenator mentioned this pull request Mar 23, 2021
Merged
@traylenator traylenator deleted the debian2 branch March 24, 2021 07:59
@hamar hamar mentioned this pull request Apr 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

@luisfdez luisfdez Awaiting requested review from luisfdez

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@traylenator @olifre @bastelfreak