Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert main config template to epp #118

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

traylenator
Copy link
Contributor

@traylenator traylenator commented Mar 12, 2021

Pull Request (PR) description

Migrate remaining erb templates to epp templates

This Pull Request (PR) fixes the following issues

The main template repo.local.erb is converted to epp as repo.local.epp. The template is used
by.

  • cvmfs::config for /etc/cvmfs/default.local
  • cvmfs::mount{'foo.example.org':} for '/etc/cvmfs/config.d/foo.example.org.local`
  • cvmfs::domain{'example.org':} for '/etc/cvmfs/domain.d/example.org.local`

Subsequently some stronger typing has been introduced internal to the module however the external interface
is expected to be equivalent.

The completly unused parameter cvmfs_force_singing was removed also however I am confident this will
not have been set anywhere.

The parameter mount::cmvfs_mount_rw is corrected to mount::cvmfs_mount_rw transpose of vm.

@traylenator traylenator force-pushed the erb2epp branch 6 times, most recently from 87700cb to d1ceb40 Compare March 15, 2021 15:50
Most cvmfs configuration is done with a single template, convert it
to epp.
@traylenator traylenator changed the title WIP: Convert main config template to epp Convert main config template to epp Mar 15, 2021
@traylenator traylenator added the enhancement New feature or request label Mar 17, 2021
Copy link
Contributor

@luisfdez luisfdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. I see some comments from other PRs are addressed here.

@traylenator traylenator merged commit df9dc8c into voxpupuli:master Mar 18, 2021
traylenator added a commit to traylenator/puppet-cvmfs that referenced this pull request Mar 23, 2021
**Breaking changes:**

- Remove 'yum' string from class parameters [\voxpupuli#123](voxpupuli#123) ([traylenator](https://github.com/traylenator))
- Add type enforcement to cvmfs::mount and cvmfs::domain [\voxpupuli#122](voxpupuli#122) ([traylenator](https://github.com/traylenator))
- Drop all CvmFS server code [\voxpupuli#113](voxpupuli#113) ([traylenator](https://github.com/traylenator))

**Implemented enhancements:**

- Add CVMFS\_IPFAMILY\_PREFER config parameter [\voxpupuli#125](voxpupuli#125) ([luisfdez](https://github.com/luisfdez))
- Add ubuntu 18.04, 20.04 and debian 10 support [\voxpupuli#124](voxpupuli#124) ([traylenator](https://github.com/traylenator))
- Convert main config template to epp [\voxpupuli#118](voxpupuli#118) ([traylenator](https://github.com/traylenator))

**Fixed bugs:**

- cvmfs\_external\_url parameter to mount fixed [\voxpupuli#127](voxpupuli#127) ([traylenator](https://github.com/traylenator))
- Correct parameter name for default case [\voxpupuli#126](voxpupuli#126) ([traylenator](https://github.com/traylenator))

**Merged pull requests:**

- Update all documentation [\voxpupuli#128](voxpupuli#128) ([traylenator](https://github.com/traylenator))
- Use modern splat rather than create resources [\voxpupuli#121](voxpupuli#121) ([traylenator](https://github.com/traylenator))
- Whitespace, Automatic lint and Rubocop Fixes [\voxpupuli#114](voxpupuli#114) ([traylenator](https://github.com/traylenator))
- Increase upper version of firewall module [\voxpupuli#112](voxpupuli#112) ([sorrison](https://github.com/sorrison))
- cvmfs::install: Fact file creation must depend on Package\[cvmfs\]. [\voxpupuli#111](voxpupuli#111) ([olifre](https://github.com/olifre))
- Add UID\_MAP and GID\_MAP functionality. [\voxpupuli#110](voxpupuli#110) ([olifre](https://github.com/olifre))
- add missing package require for file ownership [\voxpupuli#104](voxpupuli#104) ([fschaer](https://github.com/fschaer))
@traylenator traylenator mentioned this pull request Mar 23, 2021
@traylenator traylenator deleted the erb2epp branch March 24, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants