support for IPv6 nameservers #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Oct 20, 2016
| @@ -4,6 +4,7 @@ | |||
| { | |||
| 'dnsdomain' => ['sampledomain.com', '1.1.1.in-addr.arpa'], | |||
| 'nameservers' => ['1.1.1.1'], | |||
| 'nameservers_ipv6' => ['1:5ee:bad:c0de'], | |||
There was a problem hiding this comment.
This is not a valid IPv6 address. Try adding an extra : and it should at least pass validation if we decide to add it.
There was a problem hiding this comment.
Why does it need to be a valid ipv6 address? it is only used as a string in the spec test
There was a problem hiding this comment.
IMHO it's a best practice to input valid data, even in tests. While currently there's no input validation, it's better to be ready for it.
ekohl
approved these changes
Oct 20, 2016
cegeka-jenkins
pushed a commit
to cegeka/puppet-dhcp
that referenced
this pull request
Jun 26, 2020
support for IPv6 nameservers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.