allow dhcp::host to set "on EVENT" handlers #216
Conversation
manifests/host.pp
Outdated
| @@ -7,6 +7,9 @@ | |||
| Hash $options = {}, | |||
| String $comment ='', | |||
| Boolean $ignored = false, | |||
| Optional[Array[String]] $on_commit = undef, | |||
There was a problem hiding this comment.
Please align the = and enforce the minimal string length:
| Optional[Array[String]] $on_commit = undef, | |
| Optional[Array[String[1]]] $on_commit = undef, |
There was a problem hiding this comment.
Good call on this one. Update coming...
bastelfreak
added
enhancement
manifests/host.pp
Outdated
| Boolean $ignored = false, | ||
| Optional[Integer] $default_lease_time = undef, | ||
| Optional[Integer] $max_lease_time = undef, | ||
| Optional[Array[String[1]]] $on_commit = undef, |
There was a problem hiding this comment.
ah crap, I was a bit blind when I reviewed this the last time. For array we try to default to empty arrays instead of making them optional. From our review guidelines:
Are there new params with datatype Hash or Array? If possible, they should default to empty Hash/Array instead of undef. You can also enforce the datastructure like Array[String[1]]
There was a problem hiding this comment.
It'd be nice if the tests caught this. I honestly don't see what difference it makes, but a fix is in the works if it makes this project happy. IMHO, I think undef is far more appropriate to mean "not set", but that's me.
jflorian
force-pushed
the
host_on_event
branch
2 times, most recently
from
ece9e95
to
a88dc6f
Compare
This adds 3 new optional parameters to dhcp::host: * on_commit * on_release * on_expiry Each of these accepts an array of strings representing statements that dhcpd is to perform when that event occurs for that host. Signed-off-by: John Florian <jflorian@doubledog.org>
bastelfreak
force-pushed
the
host_on_event
branch
from
a88dc6f
to
616f160
Compare
|
thanks @jflorian ! |
Pull Request (PR) description
This adds 3 new optional parameters to
dhcp::host:on_commiton_releaseon_expiryEach of these accepts an array of strings representing statements that dhcpd is to perform when that event occurs for that host.
Signed-off-by: John Florian jflorian@doubledog.org
This Pull Request (PR) fixes the following issues
none have been created