Extend support for event clauses to global, pool and pool6 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
approved these changes
Feb 17, 2021
mergwyn
force-pushed
the
global_event_support
branch
2 times, most recently
from
348ca27
to
5c23ba2
Compare
|
Many apologies - I thought I had added a comment about the CentOS6 tests failing, but clearly had not, and then I forgot all about it! Rebasing my branch fixed the test issues, but resulted in rubocop errors which I have now fixed and then squashed. Hopefully, this PR is now in a state where we can proceed. |
kenyon
requested changes
Oct 31, 2021
mergwyn
force-pushed
the
global_event_support
branch
from
d2cc5cc
to
a7095ba
Compare
|
Changes made! |
kenyon
approved these changes
Oct 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The event handlers are currently only supported for dhcp::host (see #216). These handlers can also exist globally in dhcpd.conf or in the pool definition dhcpd::pool and dhcpd::pool6. This PR extends support to these cases
This Pull Request (PR) fixes the following issues
Fixes #251