Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single quotes to value. Fixes #105 #106

Merged
merged 1 commit into from
Mar 28, 2014

Conversation

dblessing
Copy link
Contributor

Adding single quotes to this line allows users to pass a string with double quotes through to the defaults file. See #105 for more information. Fixes #105.

@dblessing
Copy link
Contributor Author

CLA should be signed.

…pts values

Adding single quotes to the augeas set command allows users to pass in
ES_JAVA_OPTS with double quotes. See voxpupuli#105 for more information.

Update tests and add ES_JAVA_OPTS to assertions
@electrical
Copy link
Contributor

Very nice! I'll be adding some other system tests for it as well ( those aren't in master yet )
Will merge it as soon as i have the CLA in our list.
Thank you very much for this! :-)

@dblessing
Copy link
Contributor Author

Hi @electrical. Did the CLA come through alright? Thanks

electrical added a commit that referenced this pull request Mar 28, 2014
Add single quotes to value. Fixes #105
@electrical electrical merged commit 3bc6ad2 into voxpupuli:master Mar 28, 2014
cegeka-jenkins pushed a commit to cegeka/puppet-elasticsearch that referenced this pull request Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

init_defaults doesn't work properly with java opts values
2 participants