init_defaults doesn't work properly with java opts values

[dblessing]

One of the configs that can be set in the elasticsearch defaults file is ES_JAVA_OPTS. There are 2 issues in this module that cause settings this variable to fail.

First, I think there need to be quotes around the value in the set command - i.e. "set ES_JAVA_OPTS "values here". Right now there are no quotes.

Second, even with quotes it appears the shellvars lens doesn't like the java opts value - probably because there are spaces in it. Being able to set java_opts in this file is critical for us so we can add some GC and JMX options.

[electrical]

Interesting issue. can you give me an example value for the ES_JAVA_OPTS?
Will do some investigation on this and add testing.

[dblessing]

I found this discussion from a while back, but I think the solution is valid. http://www.redhat.com/archives/augeas-devel/2008-October/msg00023.html

In a quick test I put single quotes around the <%= value %> in defaults.erb so it looks like this:

<% @init_defaults.sort.map do |key, value| -%>
set <%= key %> '<%= value %>'
<% end -%>

Then, in my init_defaults hash I set
ES_JAVA_OPTS => '"-Dcom.sun.management.jmxremote=true -Dcom.sun.management.jmxremote.port=9012 -Dcom.sun.management.jmxremote.ssl=false"' as an example (that's double quotes wrapped in single quotes). The end result is that the set command looks like:
set ES_JAVA_OPTS '"-Dcom.sun.management.jmxremote=true -Dcom.sun.management.jmxremote.port=9012 -Dcom.sun.management.jmxremote.ssl=false"'

The double quotes carry through and end up as the following line in /etc/sysconfig/elasticsearch - and works beautifully.
ES_JAVA_OPTS="-Dcom.sun.management.jmxremote=true -Dcom.sun.management.jmxremote.port=9012 -Dcom.sun.management.jmxremote.ssl=false"

Would you be interested in a fix like this? It's completely backward compatible as far as I can tell.

[electrical]

Ahh interesting. Totally didn't expect that.
Assuming it won't cause any issues with other values ( numbers, true/false ) im happy with the fix :-)

[dblessing]

Ok, I'll see if I can write some tests. Thanks for the feedback.

[dblessing]

I made the change. I don't think it will break current tests. I'm struggling to get the tests working on my box so I'm not sure if I'll be able to add new tests.

[dblessing]

What command is needed to execute the tests? Including ENV vars? I think that's my issue.

[electrical]

Hi,

Commands are in .travis.yml file but might fail in certain scenario's because i messed something up.

bundle install
bundle exec rake spec SPEC_OPTS='--format documentation'

[dblessing]

\o/ Thank you!

[dblessing]

Updated PR #106 with tests to account for this change.