-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init_defaults doesn't work properly with java opts values #105
Comments
Interesting issue. can you give me an example value for the ES_JAVA_OPTS? |
I found this discussion from a while back, but I think the solution is valid. http://www.redhat.com/archives/augeas-devel/2008-October/msg00023.html In a quick test I put single quotes around the <%= value %> in defaults.erb so it looks like this:
Then, in my init_defaults hash I set The double quotes carry through and end up as the following line in /etc/sysconfig/elasticsearch - and works beautifully. Would you be interested in a fix like this? It's completely backward compatible as far as I can tell. |
Ahh interesting. Totally didn't expect that. |
Ok, I'll see if I can write some tests. Thanks for the feedback. |
I made the change. I don't think it will break current tests. I'm struggling to get the tests working on my box so I'm not sure if I'll be able to add new tests. |
What command is needed to execute the tests? Including ENV vars? I think that's my issue. |
Hi, Commands are in .travis.yml file but might fail in certain scenario's because i messed something up. bundle install |
\o/ Thank you! |
…pts values Adding single quotes to the augeas set command allows users to pass in ES_JAVA_OPTS with double quotes. See voxpupuli#105 for more information. Update tests and add ES_JAVA_OPTS to assertions
Updated PR #106 with tests to account for this change. |
…pts values Adding single quotes to the augeas set command allows users to pass in ES_JAVA_OPTS with double quotes. See voxpupuli#105 for more information. Update tests and add ES_JAVA_OPTS to assertions
Add single quotes to value. Fixes #105
I'm seeing this with the latest version of the module (from the forge - 0.15.0). When I try with just Anyone aware of a workaround? |
…pts values Adding single quotes to the augeas set command allows users to pass in ES_JAVA_OPTS with double quotes. See voxpupuli#105 for more information. Update tests and add ES_JAVA_OPTS to assertions
Add single quotes to value. Fixes voxpupuli#105
One of the configs that can be set in the elasticsearch defaults file is ES_JAVA_OPTS. There are 2 issues in this module that cause settings this variable to fail.
First, I think there need to be quotes around the value in the set command - i.e. "set ES_JAVA_OPTS "values here". Right now there are no quotes.
Second, even with quotes it appears the shellvars lens doesn't like the java opts value - probably because there are spaces in it. Being able to set java_opts in this file is critical for us so we can add some GC and JMX options.
The text was updated successfully, but these errors were encountered: