Install redhat-lsb-core to provide additional facts

[dhoppe]

Fixes #88
Fixes #102

[traylenator]

Have you considered just using the standard $facts['os'] ?

[dhoppe]

@traylenator I did but they do not contain the codename of a release, which is used to point to the correct .epp template.

• https://github.com/camptocamp/facterdb/blob/master/facts/3.11/centos-7-x86_64.facts#L442-L460

We could use a different directory structure like templates/$facts['os']['name']/$facts['os']['release']['major']/etc/fail2ban/jail.conf.epp but this would be a backwards incompatible change.

[traylenator]

Why backwards incompatible?

Is it not just an internal rearrangement of file locations of the templates

I'll have a better look at the module before I comment any more.

[dhoppe]

@traylenator Yes, but it affects the use because he has to change his configuration. Otherwise the templates will not be found.

[bastelfreak]

I'm not a big fan of the lsb facts. I think proper version numbers are a better approach, because those are always available and don't need additional packages. Note: The next release will already be a major one because it includes backwards-incompatible changes. But also we should not do too many of them if we can avoid it.

[gcoxmoz]

Forcing RedHat servers to install lsb-core is just the wrong direction.

• Facter gives us facts about the OS, there's no reason we need an extra package installed.
• The answers that lsb-core gives are incomplete: CentOS is $facts['os']['family'] == 'RedHat' but lsb always calls it 'Core', so we can't distinguish between CentOS7 and CentOS8 by just the lsb name.

So, this PR adds an extra package to preserve a status quo that needs to go away.

[neomilium]

@traylenator @bastelfreak I contributed some commits available in PR #135 that remove any lsb-related facts usage. Feel free to review and/or help me to test it on CentOS and RedHat. Thanks