Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move params to hiera #134

Closed
wants to merge 1 commit into from

Conversation

neomilium
Copy link
Contributor

@neomilium neomilium commented Apr 6, 2020

In order to ease maintenance, this PR modernizes the way to handle params from dedicated class to hiera.

Please note the only behavior change is related to config_file_before pickup:

  • before this PR, an OS without specified parameter pick paths-debian.conf on Debian, paths-fedora.conf on RedHat and path-fedora.conf on others.
  • now, when its different from Debian or RedHat, the user should provide this parameter.

From my point of view, we should not choose path-fedora.conf when OS is not supported… But I think that choice was motivated. If someone know why, we can now easily add specific configuration using hiera.

Please note the current hierarchy of data selection with hiera is (see hiera.yaml):

hierarchy:
  - name: 'Operating System Family'
    path: '%{facts.os.family}.yaml'

  - name: 'common'
    path: 'common.yaml'

This PR is a starting point to better handle OSes and is related to #132 and some comments in #122.

@neomilium
Copy link
Contributor Author

neomilium commented Apr 6, 2020

@gcoxmoz @alexjfisher Your opinion and review are more than welcome on this PR.

This was referenced Apr 6, 2020
@neomilium neomilium changed the title Move params to hiera WIP: Move params to hiera Apr 6, 2020
@neomilium neomilium changed the title WIP: Move params to hiera Move params to hiera Apr 6, 2020
@neomilium neomilium changed the title Move params to hiera WIP: Move params to hiera Apr 6, 2020
@neomilium neomilium changed the title WIP: Move params to hiera Move params to hiera Apr 6, 2020
@neomilium neomilium closed this Apr 11, 2020
@neomilium neomilium deleted the move-params-to-hiera branch April 11, 2020 22:31
@neomilium
Copy link
Contributor Author

Superseeded by #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant