Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to ease maintenance, this PR modernizes the way to handle params from dedicated class to hiera.
Please note the only behavior change is related to
config_file_before
pickup:paths-debian.conf
on Debian,paths-fedora.conf
on RedHat andpath-fedora.conf
on others.From my point of view, we should not choose
path-fedora.conf
when OS is not supported… But I think that choice was motivated. If someone know why, we can now easily add specific configuration using hiera.Please note the current hierarchy of data selection with hiera is (see
hiera.yaml
):This PR is a starting point to better handle OSes and is related to #132 and some comments in #122.