Ensure apt::update is run before installing Gitlab

[baurmatt]

Pull Request (PR) description

This PR ensures that apt::update is run before installing Gitlab. Otherwise the installation will fail with E: Unable to locate package gitlab-(ce|ee)

This Pull Request (PR) fixes the following issues

[baurmatt]

CI errors seem unrelated to this change.

[smortex]

@baurmatt CI should be fixed with GitLab 14.

Can you please rebase your changes on top of the main branch?

From your working directory:

git fetch origin         # Download the latest code we have here
git rebase origin/master # Move your commits on top of the main branch
git push -f              # Send the changes (-f is required because we re-wrote history)

[baurmatt]

Thanks @smortex! I'm not near a full shell for another 2-3 weeks. If this is urgent, feel free to do it yourself. I think the permission should be sufficient.

[smortex]

I think I can't edit existing commit, just add new ones on top:

romain@zappy puppet-gitlab % git remote -v
origin	git@github.com:voxpupuli/puppet-gitlab.git (fetch)
origin	git@github.com:voxpupuli/puppet-gitlab.git (push)
syseleven	git@github.com:syseleven/puppet-gitlab.git (fetch)
syseleven	git@github.com:syseleven/puppet-gitlab.git (push)
romain@zappy puppet-gitlab % git branch -vv               
* apt-dependency 576d3ee [syseleven/apt-dependency: ahead 6, behind 1] Ensure apt::update is run before installing Gitlab
  master         dec357e [origin/master] Merge pull request #391 from voxpupuli/ubuntu20
romain@zappy puppet-gitlab % git push -f
ERROR: Permission to syseleven/puppet-gitlab.git denied to smortex.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

In spite of what is said above, no isse for reading the repository :-)

But no problem for waiting a bit :-) Have a nice rest away from the shell!

[baurmatt]

@smortex Looks good now :)

[smortex]

LGTM