-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow hkp://
style URLs for repo_keyserver
URL
#102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to also add a test for this so that it doesn't get changed back.
Added test case, will need to test it offline though, travis isn't playing nice. |
👍 test case made and passes:
Please also note the apt::key regex: https://github.com/puppetlabs/puppetlabs-apt/blob/main/manifests/key.pp#L43 Maybe it should be converted to something like that? |
Sure, I think that would be an improvement, so if you want to do that, go ahead. 😃 |
We need to get #93 done to get the tests to pass. |
Added custom keyserver type with the regex. This is in my opinion cleaner then add the whole regex to init.pp. |
ready to merge ❤️ |
@hp197 Sorry for the delay. Would you be able to rebase, so that we could get this change in? |
Sure, though I'm on vacation for the next 2 weeks. If you can wait on that
I'll do it after I'm back.
…On Mon, Aug 9, 2021, 17:53 Alexander Fisher ***@***.***> wrote:
@hp197 <https://github.com/hp197> Sorry for the delay. Would you be able
to rebase, so that we could get this change in?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#102 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACKRKZFF4KU326UBETAWUZDT372W3ANCNFSM42B2SPXA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
Fixes voxpupuli#101 (squashed) - Added test - Added custom keyserver type. Reasoning: Otherwise the parameters in the init.pp file would have been completly unaligned. Existing functionality is not changed.
rebased, squashed and ready to merge (if tests pass) ❤️ |
@alexjfisher ready and tests passed |
hkp://
style URLs for repo_keyserver
URL
@hp197 Thanks! |
Fixes #101
Pull Request (PR) description
This Pull Request (PR) fixes the following issues