Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI problems #89

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Fix CI problems #89

merged 2 commits into from
Aug 11, 2020

Conversation

carljohnstone
Copy link

@carljohnstone carljohnstone commented Jul 22, 2020

Fixes for CI problems flagged on https://travis-ci.org/github/voxpupuli/puppet-gitlab_ci_runner/jobs/710915386

manifests/config.pp:18:file_ensure:WARNING:ensure set to present on file resource
manifests/init.pp:64:manifest_whitespace_opening_brace_before:ERROR:there should be a single space before an opening brace
manifests/runner.pp:55:manifest_whitespace_opening_brace_after:ERROR:there should be a single space or single newline after an opening brace
manifests/runner.pp:61:manifest_whitespace_opening_brace_after:ERROR:there should be a single space or single newline after an opening brace

and the Amazon version check from https://travis-ci.org/github/voxpupuli/puppet-gitlab_ci_runner/jobs/710919276

Where it appears that the version is being passed in as a String with Ruby 2.4 Puppet 5, not an Integer.

Fixes for CI problems flagged on https://travis-ci.org/github/voxpupuli/puppet-gitlab_ci_runner/jobs/710915386

```
manifests/config.pp:18:file_ensure:WARNING:ensure set to present on file resource
manifests/init.pp:64:manifest_whitespace_opening_brace_before:ERROR:there should be a single space before an opening brace
manifests/runner.pp:55:manifest_whitespace_opening_brace_after:ERROR:there should be a single space or single newline after an opening brace
manifests/runner.pp:61:manifest_whitespace_opening_brace_after:ERROR:there should be a single space or single newline after an opening brace
```
@baurmatt baurmatt merged commit dd79a2e into voxpupuli:master Aug 11, 2020
@carljohnstone carljohnstone deleted the ci-fixes branch August 11, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants