Fixes and tests for strict variables #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will help us get fixes for strict variables right.
Not much to see, but better than nothing.
Fixes voxpupuli#82 Using `getvar()` as it has better compatibility than `defined()` See https://tickets.puppetlabs.com/browse/PUP-4072 for example.
|
Looks like build is failing due to a recent stdlib regression. |
alexjfisher
commented
Nov 21, 2016
| @@ -18,6 +18,8 @@ matrix: | |||
| - rvm: 1.9.3 | |||
| env: PUPPET_VERSION="~> 3.0" STRICT_VARIABLES="yes" CHECK=test | |||
| - rvm: 1.9.3 | |||
| env: PUPPET_VERSION="~> 3.6.0" STRICT_VARIABLES="yes" CHECK=test | |||
There was a problem hiding this comment.
This is only in this PR temporarily. I'll get rid of it before merging.
alexjfisher
force-pushed
the
fix_strict_vars
branch
from
6d2dbee
to
5ff1ae8
Compare
alexjfisher
changed the title
|
Awesome, thanks all, will test and report back. |
|
Looks good all, was able to implement the latest release to master (note: there is no tag, you might want to update this to 2.2.3 or something) without any problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.